Use float8e4m3fn for MI350+#4280
Closed
xw285cornell wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76020875 |
xw285cornell
added a commit
to xw285cornell/FBGEMM
that referenced
this pull request
Jun 6, 2025
Summary: X-link: fairinternal/moviegen#1414 X-link: facebookresearch/FBGEMM#1358 Only MI300 supports e4m3fnuz - MI350 supports e4m3fn. So change it Reviewed By: mxz297 Differential Revision: D76020875
98e5f4d to
0602b96
Compare
xw285cornell
added a commit
to xw285cornell/FBGEMM
that referenced
this pull request
Jun 8, 2025
Summary: X-link: fairinternal/moviegen#1414 X-link: facebookresearch/FBGEMM#1358 Only MI300 supports e4m3fnuz - MI350 supports e4m3fn. So change it Reviewed By: mxz297 Differential Revision: D76020875
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76020875 |
0602b96 to
dde6254
Compare
xw285cornell
added a commit
to xw285cornell/FBGEMM
that referenced
this pull request
Jun 10, 2025
Summary: X-link: fairinternal/moviegen#1414 X-link: facebookresearch/FBGEMM#1358 Only MI300 supports e4m3fnuz - MI350 supports e4m3fn. So change it Reviewed By: mxz297 Differential Revision: D76020875
xw285cornell
added a commit
to xw285cornell/FBGEMM
that referenced
this pull request
Jun 10, 2025
Summary: X-link: fairinternal/moviegen#1414 X-link: facebookresearch/FBGEMM#1358 Only MI300 supports e4m3fnuz - MI350 supports e4m3fn. So change it Reviewed By: mxz297 Differential Revision: D76020875
dde6254 to
dc1fb45
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76020875 |
xw285cornell
added a commit
to xw285cornell/FBGEMM
that referenced
this pull request
Jun 10, 2025
Summary: Pull Request resolved: pytorch#4280 X-link: fairinternal/moviegen#1414 X-link: facebookresearch/FBGEMM#1358 Only MI300 supports e4m3fnuz - MI350 supports e4m3fn. So change it Reviewed By: mxz297 Differential Revision: D76020875
dc1fb45 to
f7fc787
Compare
Summary: Pull Request resolved: pytorch#4280 X-link: fairinternal/moviegen#1414 X-link: facebookresearch/FBGEMM#1358 Only MI300 supports e4m3fnuz - MI350 supports e4m3fn. So change it Reviewed By: mxz297 Differential Revision: D76020875
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76020875 |
f7fc787 to
834b896
Compare
Contributor
|
This pull request has been merged in 404595f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/fairinternal/moviegen/pull/1414
X-link: https://github.com/facebookresearch/FBGEMM/pull/1358
Only MI300 supports e4m3fnuz - MI350 supports e4m3fn. So change it
Differential Revision: D76020875