Partition correctness issues from performance issues when pruning configs#4261
Closed
njriasan wants to merge 2 commits into
Closed
Partition correctness issues from performance issues when pruning configs#4261njriasan wants to merge 2 commits into
njriasan wants to merge 2 commits into
Conversation
…p8_rowwise (pytorch#4259) Summary: X-link: facebookresearch/FBGEMM#1337 Disables use_cuda_graph by default to avoid the issue that its not supported with inductor. Reviewed By: karthik-man Differential Revision: D75974226
…figs Summary: X-link: facebookresearch/FBGEMM#1339 prune_configs is used to both prune "sub-optimal" configs and incorrect configs. This splits them into separate functions so when we hit the empty configs case we will never select an invalid config in the empty case. Reviewed By: karthik-man Differential Revision: D75976113
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75976113 |
Contributor
|
This pull request has been merged in ee920a6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1339
prune_configs is used to both prune "sub-optimal" configs and incorrect configs. This splits them into separate functions so when we hit the empty configs case we will never select an invalid config in the empty case.
Reviewed By: karthik-man
Differential Revision: D75976113