Create dedicated kv cache header file#4089
Closed
jwfromm wants to merge 1 commit into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74290116 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
May 7, 2025
Summary: X-link: facebookresearch/FBGEMM#1173 This diff contains a refactor of custom function stub declarations, this time focusing on kv cache operators. By creating a standalone header file, we enable users to call our custom functions through a C++ API. It also is generally better practice to use headers this way. Reviewed By: jasonjk-park, jianyuh, bradleyhd Differential Revision: D74290116
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74290116 |
Summary: X-link: facebookresearch/FBGEMM#1173 This diff contains a refactor of custom function stub declarations, this time focusing on kv cache operators. By creating a standalone header file, we enable users to call our custom functions through a C++ API. It also is generally better practice to use headers this way. Reviewed By: jasonjk-park, jianyuh, bradleyhd Differential Revision: D74290116
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74290116 |
Contributor
|
This pull request has been merged in 2c0e915. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This diff contains a refactor of custom function stub declarations, this time focusing on kv cache operators. By creating a standalone header file, we enable users to call our custom functions through a C++ API. It also is generally better practice to use headers this way.
Reviewed By: bradleyhd
Differential Revision: D74290116