Replace rms_norm as norm#3841
Closed
jianyuh wants to merge 1 commit into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71268903 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Mar 18, 2025
Summary: X-link: facebookresearch/FBGEMM#918 qk norm applies L2 norm, not rms norm. So we just use k_norm instead of k_rms_norm. Reviewed By: jasonjk-park, Aya-ZIbra Differential Revision: D71268903
jianyuh
force-pushed
the
export-D71268903
branch
from
ad596fc to
996de6c
Compare
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Mar 18, 2025
Summary: X-link: facebookresearch/FBGEMM#918 qk norm applies L2 norm, not rms norm. So we just use k_norm instead of k_rms_norm. Reviewed By: jasonjk-park, Aya-ZIbra Differential Revision: D71268903
jianyuh
force-pushed
the
export-D71268903
branch
from
996de6c to
474f5be
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71268903 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Mar 18, 2025
Summary: Pull Request resolved: pytorch#3841 X-link: facebookresearch/FBGEMM#918 qk norm applies L2 norm, not rms norm. So we just use k_norm instead of k_rms_norm. Reviewed By: jasonjk-park, Aya-ZIbra Differential Revision: D71268903
jianyuh
force-pushed
the
export-D71268903
branch
from
474f5be to
a75a758
Compare
Summary: Pull Request resolved: pytorch#3841 X-link: facebookresearch/FBGEMM#918 qk norm applies L2 norm, not rms norm. So we just use k_norm instead of k_rms_norm. Reviewed By: jasonjk-park, Aya-ZIbra Differential Revision: D71268903
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71268903 |
jianyuh
force-pushed
the
export-D71268903
branch
from
a75a758 to
b7e4a34
Compare
Contributor
|
This pull request has been merged in 89c2d0d. |
liligwu
pushed a commit
to ROCm/FBGEMM
that referenced
this pull request
Mar 19, 2025
Summary: Pull Request resolved: pytorch#3841 X-link: https://github.com/facebookresearch/FBGEMM/pull/918 qk norm applies L2 norm, not rms norm. So we just use k_norm instead of k_rms_norm. Reviewed By: jasonjk-park, Aya-ZIbra Differential Revision: D71268903 fbshipit-source-id: aa5ad2ea795a718843d6c15a9dee03e9b332b860
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/918
qk norm applies L2 norm, not rms norm. So we just use k_norm instead of k_rms_norm.
Reviewed By: jasonjk-park, Aya-ZIbra
Differential Revision: D71268903