coro => fut#3430
Closed
duduyi2013 wants to merge 2 commits into
Closed
Conversation
Summary: X-link: facebookresearch/FBGEMM#516 changeset 1. make L2/rocksdb async update optional 2. update assertion into check, since assert doesn't work 3. adjust locking mechanism Differential Revision: D66550003
Summary: update all the coro to future Differential Revision: D66550002
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66550002 |
duduyi2013
added a commit
to duduyi2013/FBGEMM
that referenced
this pull request
Dec 3, 2024
Summary: X-link: facebookresearch/FBGEMM#517 update all the coro to future We saw memory management problem in the current stack, after enabling opt-asan and reduce the stack tot he simplest version, it seems related to using coro, we have made [a post on the coro group](https://fb.workplace.com/groups/192968587972839/permalink/1626473334622350/), but didn't get much helpful information. To unblock ourselves, we found that using folly::future remediate the problem. This diff changes all the parallel mechanism from coro to future. Reviewed By: chrisxcai Differential Revision: D66550002
Contributor
|
This pull request has been merged in 36b454d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: update all the coro to future
Differential Revision: D66550002