Remove triton.ops dependency from fbgemm#3329
Closed
embg wants to merge 1 commit into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65496960 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Nov 5, 2024
Summary: 3.2.x moves triton.ops to a seperate github repo. Since fbgemm only depends on triton.ops in a single place, we can simply copy-paste the upstream file. Copied the file from here: https://github.com/triton-lang/kernels/blob/8821ef322394ee2d3c58a859780ee1e2e10b5c79/kernels/matmul_perf_model.py Reviewed By: bertmaher, davidberard98 Differential Revision: D65496960
embg
force-pushed
the
export-D65496960
branch
from
673e0a5 to
f1eea5a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65496960 |
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Nov 5, 2024
Summary: X-link: facebookresearch/FBGEMM#423 3.2.x moves triton.ops to a seperate github repo. Since fbgemm only depends on triton.ops in a single place, we can simply copy-paste the upstream file. Copied the file from here: https://github.com/triton-lang/kernels/blob/8821ef322394ee2d3c58a859780ee1e2e10b5c79/kernels/matmul_perf_model.py Reviewed By: bertmaher, davidberard98 Differential Revision: D65496960
embg
force-pushed
the
export-D65496960
branch
from
f1eea5a to
6f02799
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65496960 |
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Nov 5, 2024
Summary: X-link: facebookresearch/FBGEMM#423 3.2.x moves triton.ops to a seperate github repo. Since fbgemm only depends on triton.ops in a single place, we can simply copy-paste the upstream file. Copied the file from here: https://github.com/triton-lang/kernels/blob/8821ef322394ee2d3c58a859780ee1e2e10b5c79/kernels/matmul_perf_model.py Reviewed By: bertmaher, q10, davidberard98 Differential Revision: D65496960
embg
force-pushed
the
export-D65496960
branch
from
6f02799 to
2aadd33
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65496960 |
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Nov 5, 2024
Summary: X-link: facebookresearch/FBGEMM#423 3.2.x moves triton.ops to a seperate github repo. Since fbgemm only depends on triton.ops in a single place, we can simply copy-paste the upstream file. Copied the file from here: https://github.com/triton-lang/kernels/blob/8821ef322394ee2d3c58a859780ee1e2e10b5c79/kernels/matmul_perf_model.py Reviewed By: bertmaher, q10, davidberard98 Differential Revision: D65496960
embg
force-pushed
the
export-D65496960
branch
from
2aadd33 to
fcb3a17
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65496960 |
embg
pushed a commit
to embg/FBGEMM
that referenced
this pull request
Nov 5, 2024
Summary: X-link: facebookresearch/FBGEMM#423 3.2.x moves triton.ops to a seperate github repo. Since fbgemm only depends on triton.ops in a single place, we can simply copy-paste the upstream file. Copied the file from here: https://github.com/triton-lang/kernels/blob/8821ef322394ee2d3c58a859780ee1e2e10b5c79/kernels/matmul_perf_model.py Reviewed By: bertmaher, q10, davidberard98 Differential Revision: D65496960
embg
force-pushed
the
export-D65496960
branch
from
fcb3a17 to
1005c8a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65496960 |
Summary: X-link: facebookresearch/FBGEMM#423 3.2.x moves triton.ops to a seperate github repo. Since fbgemm only depends on triton.ops in a single place, we can simply copy-paste the upstream file. Copied the file from here: https://github.com/triton-lang/kernels/blob/8821ef322394ee2d3c58a859780ee1e2e10b5c79/kernels/matmul_perf_model.py Reviewed By: bertmaher, q10, davidberard98 Differential Revision: D65496960
embg
force-pushed
the
export-D65496960
branch
from
1005c8a to
807b79e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65496960 |
Contributor
|
This pull request has been merged in a3da0f3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
3.2.x moves triton.ops to a seperate github repo. Since fbgemm only depends on triton.ops in a single place, we can simply copy-paste the upstream file.
Copied the file from here: https://github.com/triton-lang/kernels/blob/8821ef322394ee2d3c58a859780ee1e2e10b5c79/kernels/matmul_perf_model.py
Reviewed By: davidberard98
Differential Revision: D65496960