FBGEMM/TorchRec MX4 padding support#3055
Closed
qchip wants to merge 1 commit into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61985037 |
❌ Deploy Preview for pytorch-fbgemm-docs failed.
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Summary: X-link: facebookresearch/FBGEMM#151 rowwise padding is needed to fix NE of Ads ranking models for AlltoAll communication with MX4. Differential Revision: D61985037
5f92e8e to
26e1431
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61985037 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Summary: X-link: facebookresearch/FBGEMM#151 rowwise padding is needed to fix NE of Ads ranking models for AlltoAll communication with MX4. Differential Revision: D61985037
26e1431 to
4167b75
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61985037 |
Summary: X-link: facebookresearch/FBGEMM#151 rowwise padding is needed to fix NE of Ads ranking models for AlltoAll communication with MX4. Differential Revision: D61985037
4167b75 to
f152f38
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61985037 |
Contributor
|
This pull request has been merged in 23beb06. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: rowwise padding is needed to fix NE of Ads ranking models for AlltoAll communication with MX4.
Differential Revision: D61985037