Integrate CK PR1453#2971
Closed
zjing14 wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60996231 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60996231 |
zjing14
added a commit
to zjing14/FBGEMM
that referenced
this pull request
Aug 12, 2024
Summary: Integrate ROCm/composable_kernel#1453 and disable conditional OOB check, which improves both memory bound and compute bound cases * Add a flag expect better register allocation * Enabled bf16 atomic_add D60544251 * Add 256x256x128 tile for fp8 gemm * Optimize OOB check strategy, reduce conditional mask usage and instance number of gemm_multiply_multiply. * Disable conditional OOB check Pull Request resolved: pytorch#2971 X-link: facebookresearch/FBGEMM#68 Differential Revision: D60996231
zjing14
force-pushed
the
export-D60996231
branch
from
2217233 to
e8ebd12
Compare
Summary: Integrate ROCm/composable_kernel#1453 and disable conditional OOB check, which improves both memory bound and compute bound cases * Add a flag expect better register allocation * Enabled bf16 atomic_add D60544251 * Add 256x256x128 tile for fp8 gemm * Optimize OOB check strategy, reduce conditional mask usage and instance number of gemm_multiply_multiply. * Disable conditional OOB check Pull Request resolved: pytorch#2971 X-link: facebookresearch/FBGEMM#68 Differential Revision: D60996231
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60996231 |
zjing14
force-pushed
the
export-D60996231
branch
from
e8ebd12 to
2f189e5
Compare
Contributor
|
This pull request has been merged in 440cbb0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Integrate ROCm/composable_kernel#1453
Differential Revision: D60996231