clean up permute_duplicate_pooled_* in python#2891
Closed
TroyGarden wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50658317 |
Summary: Pull Request resolved: pytorch#2891 # context * these `permute_duplicate_pooled_emb*` functions are not used * clean up the python callsites * keep the cpp/cu for backward compatibility Differential Revision: D50658317
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50658317 |
TroyGarden
force-pushed
the
export-D50658317
branch
from
52e96db to
c0fd32a
Compare
Contributor
|
This pull request has been merged in 3e5cbf6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
context
permute_duplicate_pooled_emb*functions are not usedDifferential Revision: D50658317