Increase memcpy and compute overlap#2860
Closed
sryap wants to merge 3 commits into
Closed
Conversation
Differential Revision: D59795139
Differential Revision: D59716516
Summary: This diff introduces a small optimization for device-host memory copy to increase the overlap with the compute kernels. Changes include: - Transfer `evicted_indices` early on the `ssd_eviction_stream` stream (for cache eviction) - Transfer `post_bwd_evicted_indices` early on the `ssd_eviction_stream` stream (for scratch pad eviction) - Transfer `actions_count` and `inserted_indices` early on the `ssd_memcpy_stream` stream (for get) Differential Revision: D59866892
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59866892 |
Contributor
|
This pull request has been merged in d6790d0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff introduces a small optimization for device-host memory copy
to increase the overlap with the compute kernels.
Changes include:
evicted_indicesearly on thessd_eviction_streamstream(for cache eviction)
post_bwd_evicted_indicesearly on thessd_eviction_streamstream (for scratch pad eviction)actions_countandinserted_indicesearly on thessd_memcpy_streamstream (for get)Differential Revision: D59866892