Create an abstract class for EmbeddingKVDB#2642
Closed
sryap wants to merge 1 commit into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56652728 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
May 29, 2024
Summary: This diff adds a base class called `EmbeddingKVDB` for TBE's key-value database extension. For more details about the interface, please see https://fburl.com/gdoc/e3q3jans Differential Revision: D56652728
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56652728 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56652728 |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
May 30, 2024
Summary: Pull Request resolved: pytorch#2642 This diff adds a base class called `EmbeddingKVDB` for TBE's key-value database extension. For more details about the interface, please see https://fburl.com/gdoc/e3q3jans Differential Revision: D56652728
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56652728 |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
May 30, 2024
Summary: Pull Request resolved: pytorch#2642 This diff adds a base class called `EmbeddingKVDB` for TBE's key-value database extension. For more details about the interface, please see https://fburl.com/gdoc/e3q3jans Reviewed By: henrylhtsang Differential Revision: D56652728
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56652728 |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
May 30, 2024
Summary: Pull Request resolved: pytorch#2642 This diff adds a base class called `EmbeddingKVDB` for TBE's key-value database extension. For more details about the interface, please see https://fburl.com/gdoc/e3q3jans Reviewed By: henrylhtsang Differential Revision: D56652728
Summary: This diff adds a base class called `EmbeddingKVDB` for TBE's key-value database extension. For more details about the interface, please see https://fburl.com/gdoc/e3q3jans Reviewed By: henrylhtsang Differential Revision: D56652728
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56652728 |
Contributor
|
This pull request has been merged in 5e6c487. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds a base class called
EmbeddingKVDBfor TBE's key-valuedatabase extension. For more details about the interface, please see
https://fburl.com/gdoc/e3q3jans
Differential Revision: D56652728