STBE GPU coalescing kernel#2275
Closed
YazhiGao wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52903658 |
YazhiGao
pushed a commit
to YazhiGao/FBGEMM
that referenced
this pull request
Jan 20, 2024
Summary: * this is a follow up on GPU coalescing of stbe output, we follow the old idea of sparse feature rebatching to enable this. sequence embedding is afterall jagged tensor in dim D and stbe output is well aligned with input as [sum_l(T, B), D]. * we explictly fork code for avoiding spaming all function into one reorder kernel suite. Differential Revision: D52903658
YazhiGao
force-pushed
the
export-D52903658
branch
from
d3f1fea to
ef7238b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52903658 |
Summary: * this is a follow up on GPU coalescing of stbe output, we follow the old idea of sparse feature rebatching to enable this. sequence embedding is afterall jagged tensor in dim D and stbe output is well aligned with input as [sum_l(T, B), D]. * we explictly fork code for avoiding spaming all function into one reorder kernel suite. Reviewed By: jspark1105, 842974287 Differential Revision: D52903658
YazhiGao
force-pushed
the
export-D52903658
branch
from
ef7238b to
af9e290
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52903658 |
Contributor
|
This pull request has been merged in 17a0604. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D52903658