Skip to content

Collection is Sized #8977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 7 commits into from
Oct 25, 2022
Merged

Collection is Sized #8977

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d5a3102
`Collection` is `Sized`
sobolevn Oct 24, 2022
ffcb18b
Update typing.pyi
sobolevn Oct 24, 2022
52c7366
Add a test case
sobolevn Oct 25, 2022
f4e4bdc
Merge branch 'collection-is-sized' of https://github.com/sobolevn/typ…
sobolevn Oct 25, 2022
0e9cab7
Add a comment
sobolevn Oct 25, 2022
3533799
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 25, 2022
7fdb21b
Revert adding a test case
sobolevn Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdlib/builtins.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@ class bytearray(MutableSequence[int], ByteString):
def __alloc__(self) -> int: ...

@final
class memoryview(Sized, Sequence[int]):
class memoryview(Sequence[int]):
@property
def format(self) -> str: ...
@property
Expand Down
3 changes: 1 addition & 2 deletions stdlib/typing.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,8 +452,7 @@ class Container(Protocol[_T_co]):
def __contains__(self, __x: object) -> bool: ...

@runtime_checkable
class Collection(Iterable[_T_co], Container[_T_co], Protocol[_T_co]):
# Implement Sized (but don't have it as a base class).
class Collection(Sized, Iterable[_T_co], Container[_T_co], Protocol[_T_co]):
@abstractmethod
def __len__(self) -> int: ...

Expand Down