PEP 582: Add more explanation based on feedback #2983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
reviewed
Jan 25, 2023
kushaldas
force-pushed
the
582_feedback_update
branch
from
6dcf87b to
47e348a
Compare
CAM-Gerlach
changed the title
CAM-Gerlach
reviewed
Jan 26, 2023
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
Fix a handful of grammar, phrasing, clarity and syntax issues
(Standard reminder: You can apply the suggestions you want in one go with Files changed -> Add to batch -> Commit)
Adds explanation of handling `bin/` directory, or how we are not trying to replace the existing virtual environments.
kushaldas
force-pushed
the
582_feedback_update
branch
from
1c88379 to
b3335ba
Compare
Member
Author
|
@CAM-Gerlach I updated the branch with the suggestions. |
CAM-Gerlach
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds explanation of handling
bin/directory, or how we are not trying to replace the existing virtual environments.