-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 701: Incorporate more feedback from the discussion thread #2974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
efc1834 to
65f9252
Compare
Signed-off-by: Pablo Galindo <[email protected]>
65f9252 to
2bfe6d5
Compare
Co-authored-by: Shantanu <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Batuhan Taskaya <[email protected]>
lysnikolaou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments here.
CAM-Gerlach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few reST syntax comments and suggested grammar/phrasing fixes on the last bit; skimming the other changes, I noticed some other missing commas and grammar/phrasing issues that made it less easy to read than it could be, but I didn't want add a bunch more unsolicited suggestions. If you'd like me to copyedit it here via GitHub suggestions, or as a follow, just let me know.
Co-authored-by: Lysandros Nikolaou <[email protected]> Co-authored-by: C.A.M. Gerlach <[email protected]>
|
Thanks a lot @CAM-Gerlach for the fantastic suggestions! |
|
Yup, that sounds best to me, particularly since I'm going to need to focus on completing my research/degree as my first priority in the next couple months, so I can't promise I'll get to it right away anyway and don't want to hold this one up. |
Best of luck for that research/degree! 🤘 |
No description provided.