Skip to content

Conversation

@pablogsal
Copy link
Member

No description provided.

Co-authored-by: Shantanu <[email protected]>
pablogsal and others added 2 commits January 22, 2023 13:46
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Batuhan Taskaya <[email protected]>
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments here.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few reST syntax comments and suggested grammar/phrasing fixes on the last bit; skimming the other changes, I noticed some other missing commas and grammar/phrasing issues that made it less easy to read than it could be, but I didn't want add a bunch more unsolicited suggestions. If you'd like me to copyedit it here via GitHub suggestions, or as a follow, just let me know.

Co-authored-by: Lysandros Nikolaou <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
@pablogsal
Copy link
Member Author

Thanks a lot @CAM-Gerlach for the fantastic suggestions!

@pablogsal
Copy link
Member Author

pablogsal commented Jan 27, 2023

If you'd like me to copyedit it here via GitHub suggestions, or as a follow, just let me know.

Here is fine if you are ok with that Edit: this is getting quite big, so let's do those as a follow up

@CAM-Gerlach
Copy link
Member

Edit: this is getting quite big, so let's do those as a follow up

Yup, that sounds best to me, particularly since I'm going to need to focus on completing my research/degree as my first priority in the next couple months, so I can't promise I'll get to it right away anyway and don't want to hold this one up.

@pablogsal pablogsal merged commit 32eab93 into python:main Jan 28, 2023
@pablogsal
Copy link
Member Author

pablogsal commented Jan 28, 2023

Edit: this is getting quite big, so let's do those as a follow up

Yup, that sounds best to me, particularly since I'm going to need to focus on completing my research/degree as my first priority in the next couple months, so I can't promise I'll get to it right away anyway and don't want to hold this one up.

Best of luck for that research/degree! 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants