Skip to content

bpo-40956: Convert _sqlite3.Cursor to Argument Clinic #24007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berkerpeksag merged 6 commits into from
Jan 5, 2021
Merged

bpo-40956: Convert _sqlite3.Cursor to Argument Clinic #24007

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8790dc
Convert _sqlite3.Cursor to Argument Clinic
Jun 13, 2020
e9535b8
Address review: fix execute() and executemany() specs
Dec 30, 2020
64b9c36
Fix naming
Dec 30, 2020
935140d
The sizes argument of setinputsizes() is not optional, according to P…
Dec 30, 2020
829f23a
Address review: for executemany(), use seq_of_parameters in C also
Dec 30, 2020
5daced3
Merge branch 'master' into bpo-40956/part4-cursor
Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions Modules/_sqlite/clinic/cursor.c.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ pysqlite_cursor_init(PyObject *self, PyObject *args, PyObject *kwargs)
}

PyDoc_STRVAR(pysqlite_cursor_execute__doc__,
"execute($self, sql, parameters=<unrepresentable>, /)\n"
"execute($self, sql, parameters=(), /)\n"
"--\n"
"\n"
"Executes a SQL statement.");
Expand Down Expand Up @@ -73,7 +73,7 @@ pysqlite_cursor_execute(pysqlite_Cursor *self, PyObject *const *args, Py_ssize_t
}

PyDoc_STRVAR(pysqlite_cursor_executemany__doc__,
"executemany($self, sql, parameters=<unrepresentable>, /)\n"
"executemany($self, sql, seq_of_parameters, /)\n"
"--\n"
"\n"
"Repeatedly executes a SQL statement.");
Expand All @@ -90,9 +90,9 @@ pysqlite_cursor_executemany(pysqlite_Cursor *self, PyObject *const *args, Py_ssi
{
PyObject *return_value = NULL;
PyObject *sql;
PyObject *parameters = NULL;
PyObject *parameters;

if (!_PyArg_CheckPositional("executemany", nargs, 1, 2)) {
if (!_PyArg_CheckPositional("executemany", nargs, 2, 2)) {
goto exit;
}
if (!PyUnicode_Check(args[0])) {
Expand All @@ -103,11 +103,7 @@ pysqlite_cursor_executemany(pysqlite_Cursor *self, PyObject *const *args, Py_ssi
goto exit;
}
sql = args[0];
if (nargs < 2) {
goto skip_optional;
}
parameters = args[1];
skip_optional:
return_value = pysqlite_cursor_executemany_impl(self, sql, parameters);

exit:
Expand Down Expand Up @@ -283,4 +279,4 @@ pysqlite_cursor_close(pysqlite_Cursor *self, PyObject *Py_UNUSED(ignored))
{
return pysqlite_cursor_close_impl(self);
}
/*[clinic end generated code: output=29b5b24ed34ba996 input=a9049054013a1b77]*/
/*[clinic end generated code: output=99f4f8ae754cf21c input=a9049054013a1b77]*/
8 changes: 4 additions & 4 deletions Modules/_sqlite/cursor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ _pysqlite_query_execute(pysqlite_Cursor* self, int multiple, PyObject* operation
_sqlite3.Cursor.execute as pysqlite_cursor_execute

sql: unicode
parameters: object = NULL
parameters: object(c_default = 'NULL') = ()
/

Executes a SQL statement.
Expand All @@ -622,7 +622,7 @@ Executes a SQL statement.
static PyObject *
pysqlite_cursor_execute_impl(pysqlite_Cursor *self, PyObject *sql,
PyObject *parameters)
/*[clinic end generated code: output=d81b4655c7c0bbad input=f146ded55ff8c7d4]*/
/*[clinic end generated code: output=d81b4655c7c0bbad input=91d7bb36f127f597]*/
{
return _pysqlite_query_execute(self, 0, sql, parameters);
}
Expand All @@ -631,7 +631,7 @@ pysqlite_cursor_execute_impl(pysqlite_Cursor *self, PyObject *sql,
_sqlite3.Cursor.executemany as pysqlite_cursor_executemany

sql: unicode
parameters: object = NULL
seq_of_parameters as parameters: object
/

Repeatedly executes a SQL statement.
Expand All @@ -640,7 +640,7 @@ Repeatedly executes a SQL statement.
static PyObject *
pysqlite_cursor_executemany_impl(pysqlite_Cursor *self, PyObject *sql,
PyObject *parameters)
/*[clinic end generated code: output=df8e2d0b7300aab6 input=fa99d0eb3dd5971e]*/
/*[clinic end generated code: output=df8e2d0b7300aab6 input=d8bbe53a5634f68d]*/
{
return _pysqlite_query_execute(self, 1, sql, parameters);
}
Expand Down