Skip to content

bpo-39101: Fixes BaseException hang in IsolatedAsyncioTestCase. #22654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lisroach merged 3 commits into from
Oct 26, 2020
Merged

bpo-39101: Fixes BaseException hang in IsolatedAsyncioTestCase. #22654

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4552921
[bpo-39101] Fixes BaseException hang in IsolatedAsyncioTestCase.
lisroach Oct 11, 2020
34af5d1
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 11, 2020
1e268cb
Moves System and Keyboard exception to use raise, Cancelled does not.
lisroach Oct 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/unittest/async_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ async def _asyncioLoopRunner(self, fut):
fut.set_result(ret)
except asyncio.CancelledError:
Copy link
Member

@1st1 1st1 Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add except (SystemExit, KeyboardInterrupt): raise before handling the BaseException.

Copy link
Contributor Author

@lisroach lisroach Oct 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1st1 this will still leave SystemExit and KeyboardInterrupt hanging if they are raised, I think they should be handled along with the BaseException.

raise
except Exception as ex:
except BaseException as ex:
if not fut.cancelled():
fut.set_exception(ex)

Expand Down
18 changes: 18 additions & 0 deletions Lib/unittest/test/test_async_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,24 @@ async def on_async_cleanup(self, val):
'async_cleanup 2',
'sync_cleanup 1'])

def test_base_exception_from_async_method(self):
events = []
class Test(unittest.IsolatedAsyncioTestCase):
async def test_a(self):
events.append("test_a")
raise BaseException()
events.append("not it")

async def test_b(self):
events.append("test_b")

test = Test("test_a")
output = test.run()
self.assertFalse(output.wasSuccessful())

test = Test("test_b")
test.run()
self.assertEqual(events, ['test_a', 'test_b'])

if __name__ == "__main__":
unittest.main()
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2020-10-11-21-43-03.bpo-39101.-I49Pm.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed tests using IsolatedAsyncioTestCase from hanging on BaseExceptions.