Skip to content

[3.6] bpo-38576: Disallow control characters in hostnames in http.client (GH-18995) #19002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2020
Merged

[3.6] bpo-38576: Disallow control characters in hostnames in http.client (GH-18995) #19002

merged 1 commit into from
Mar 14, 2020

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 14, 2020 •
edited by bedevere-bot
Loading

Add host validation for control characters for more CVE-2019-18348 protection.
(cherry picked from commit 9165add)

Co-authored-by: Ashwin Ramaswami [email protected]

https://bugs.python.org/issue38576

@epicfaace @miss-islington
bpo-38576: Disallow control characters in hostnames in http.client (p…
1e24df6 
…ythonGH-18995)

Add host validation for control characters for more CVE-2019-18348 protection.
(cherry picked from commit 9165add)

Co-authored-by: Ashwin Ramaswami <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Mar 14, 2020
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error type-security A security issue awaiting review labels Mar 14, 2020
@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 14, 2020

@epicfaace and @gpshead: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 14, 2020

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 14, 2020

@epicfaace and @gpshead: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Mar 14, 2020

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

@ned-deily ned-deily merged commit 83fc701 into python:3.6 Mar 14, 2020
@miss-islington miss-islington deleted the backport-9165add-3.6 branch March 14, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@ned-deily ned-deily

Labels

type-bug An unexpected behavior, bug, or error type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miss-islington @gpshead @ned-deily @the-knights-who-say-ni @bedevere-bot @epicfaace