Skip to content

bpo-38337: Change getattr to inspect.getattr_static #16521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3j14 wants to merge 8 commits into from
Closed

bpo-38337: Change getattr to inspect.getattr_static #16521

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ba746bc
Change getattr to inspect.getattr_static
3j14 Oct 1, 2019
80fcfb4
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 1, 2019
434a3e6
Update NEWS entry
3j14 Oct 1, 2019
db038c5
Add test for inspect.getmembers
3j14 Oct 1, 2019
8a95946
Assert whether the property is in the list
3j14 Oct 1, 2019
b415224
Fix constructor without self
3j14 Oct 3, 2019
64f5954
bpo-38337: Fix whitespace in test_inspect
3j14 Oct 3, 2019
3ac2093
bpo-38337: Only use getattr_static for properties
3j14 Oct 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Lib/inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,10 @@ def getmembers(object, predicate=None):
# like calling their __get__ (see bug #1785), so fall back to
# looking in the __dict__.
try:
value = getattr_static(object, key)
if isinstance(getattr_static(object, key), property):
Copy link
Member

@1st1 1st1 Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we always use getattr_static? If there's a reason for not using it always, please describe that in a comment.

Copy link
Author

@3j14 3j14 Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is related to my latest comment. Sorry, I didn't make this clear:

getattr_static(...,'__class__') returns <attribute '__class__' of 'object' objects> whereas getattr would return <class '__main__.Foo'>. What should getmembers return? Using getattr_static for every attribute doesn't seem to be the solution. It works fine with methods, functions and properties, but some edge cases seem to require getattr (such as __class__). It is not clear what the expected behaviour is.

Copy link
Member

@1st1 1st1 Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, well, describe this in a comment :)

value = getattr_static(object, key)
else:
value = getattr(object, key)
# handle the duplicate key
if key in processed:
raise AttributeError
Expand Down