Skip to content

bpo-38037: Fix reference counters in signal module #15701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 6 commits into from
Closed

bpo-38037: Fix reference counters in signal module #15701

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3b768db
Fix ref leaks in signal module
wjssz Sep 5, 2019
27beec8
add another one
wjssz Sep 5, 2019
c3a436b
remove a local variable `x`
wjssz Sep 6, 2019
a0f335c
Py_DECREF if PyModule_AddObject fails
wjssz Sep 6, 2019
211fb1a
update News Entry
animalize Sep 7, 2019
1bebb4d
add {...} to if blocks
wjssz Sep 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2019-09-05-22-09-38.bpo-38037.xA66nY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix ref leaks in signal module.
3 changes: 3 additions & 0 deletions Modules/signalmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,10 +1351,12 @@ PyInit__signal(void)
d = PyModule_GetDict(m);

x = DefaultHandler = PyLong_FromVoidPtr((void *)SIG_DFL);
Py_XINCREF(x);
if (PyModule_AddObject(m, "SIG_DFL", x))
goto finally;

x = IgnoreHandler = PyLong_FromVoidPtr((void *)SIG_IGN);
Py_XINCREF(x);
if (PyModule_AddObject(m, "SIG_IGN", x))
goto finally;

Expand Down Expand Up @@ -1568,6 +1570,7 @@ PyInit__signal(void)
#if defined (HAVE_SETITIMER) || defined (HAVE_GETITIMER)
ItimerError = PyErr_NewException("signal.ItimerError",
PyExc_OSError, NULL);
Py_XINCREF(ItimerError);
if (PyModule_AddObject(m, "ItimerError", ItimerError))
goto finally;
#endif
Expand Down