Skip to content

Conversation

@tirkarthi
Copy link
Member

No description provided.

@tirkarthi
Copy link
Member Author

I am not a native English speaker I think it should be "Apple's guidelines" instead of "Apple guidelines" in idlelib.

@matrixise
Copy link
Member

Do we need a back port to 3.7?

@tirkarthi
Copy link
Member Author

Except for "guidlines" in idlelib the other two are 3.8 only.

@csabella
Copy link
Contributor

@terryjreedy usually likes to make the IDLE doc fixes into their own separate PR, so you may want to wait for him to comment.

@terryjreedy
Copy link
Member

My typo, thanks for catching. Nouns can be used as adjectives, so 'Apple guidelines' is OK, with a slightly different sense from 'Apple's guidelines'. But I will consider opinions on which seems better, especially for beginners.

Changes to idle.rst should not only be backported, but need to be propagated to idlelib/help.html, which change also should be backported. It is easier to do it in a separate PR, which I will do.

@matrixise matrixise added the docs Documentation in the Doc dir label May 15, 2019
@tirkarthi
Copy link
Member Author

Changes to idle.rst should not only be backported, but need to be propagated to idlelib/help.html, which change also should be backported. It is easier to do it in a separate PR, which I will do.

Do you want me to revert idlelib changes from this PR? The other two typos are 3.8 only. Hence backport might require manual work.

@terryjreedy terryjreedy merged commit 9b5a0ef into python:master May 16, 2019
@bedevere-bot
Copy link

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

@terryjreedy
Copy link
Member

Follow-up is #13354.

@tirkarthi
Copy link
Member Author

Thanks @terryjreedy

@tirkarthi tirkarthi deleted the fix-typo branch May 26, 2019 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants