Skip to content

gh-112186: Improve test case test_loop_is_closed_resource_warnings #112187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 3 commits into from
Nov 19, 2023
Merged

gh-112186: Improve test case test_loop_is_closed_resource_warnings #112187

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18964af
use self.assertRaises instead
dpr-0 Nov 17, 2023
68f1f71
move comment under assert
dpr-0 Nov 17, 2023
f3020a3
Indent comment
gvanrossum Nov 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions Lib/test/test_asyncio/test_streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,13 +1122,10 @@ async def inner(httpd):
self.loop.set_exception_handler(lambda loop, ctx: messages.append(ctx))

with test_utils.run_test_server() as httpd:
try:
self.loop.run_until_complete(inner(httpd))
# This exception is caused by `self.loop.stop()` as expected.
except RuntimeError:
pass
finally:
gc.collect()
with self.assertRaises(RuntimeError):
self.loop.run_until_complete(inner(httpd))
gc.collect()

self.assertEqual(messages, [])

Expand Down