Skip to content

gh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath #103842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ned-deily merged 4 commits into from
May 19, 2023
Merged

gh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath #103842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51eef68
Try building without tommath.h
chrstphrchvz Apr 22, 2023
6a6ee4f
Add blurb
chrstphrchvz Apr 25, 2023
b215a0f
Don’t always define TCL_NO_TOMMATH_H
chrstphrchvz Apr 25, 2023
08fd222
Merge branch 'main' into patch-103839
chrstphrchvz May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2023-04-25-16-31-00.gh-issue-103839.tpyLhI.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Avoid compilation error due to tommath.h not being found when building
Tkinter against Tcl 8.7 built with bundled libtommath.
3 changes: 3 additions & 0 deletions Modules/_tkinter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ Copyright (C) 1994 Steen Lumholt.
#error "Tk older than 8.5.12 not supported"
#endif

#ifndef TCL_WITH_EXTERNAL_TOMMATH
#define TCL_NO_TOMMATH_H
#endif
#include <tclTomMath.h>

#if !(defined(MS_WINDOWS) || defined(__CYGWIN__))
Expand Down