struct timeval is not declared

[mithil467]

BPO	38682
Nosy	@pfmoore, @tjguk, @zware, @zooba, @Mithil467, @iritkatriel

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2022-01-29.20:02:00.670>
created_at = <Date 2019-11-04.09:36:12.418>
labels = ['build', '3.7', 'OS-windows']
title = 'struct timeval is not declared'
updated_at = <Date 2022-01-29.20:02:00.669>
user = 'https://github.com/mithil467'

bugs.python.org fields:

activity = <Date 2022-01-29.20:02:00.669>
actor = 'iritkatriel'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-29.20:02:00.670>
closer = 'iritkatriel'
components = ['Windows']
creation = <Date 2019-11-04.09:36:12.418>
creator = 'Mithil'
dependencies = []
files = []
hgrepos = []
issue_num = 38682
keywords = []
message_count = 2.0
messages = ['355932', '412101']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'Mithil', 'iritkatriel']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue38682'
versions = ['Python 3.7']

[mithil467]

pytime.h compilation gives warnings -

pytime.h:123:59: warning: 'struct timeval' declared inside parameter list will not be visible outside of this definition or declaration
 PyAPI_FUNC(int) _PyTime_FromTimeval(_PyTime_t *tp, struct timeval *tv);
                                                           ^~~~~~~
pytime.h:130:12: warning: 'struct timeval' declared inside parameter list will not be visible outside of this definition or declaration
     struct timeval *tv,
            ^~~~~~~
pytime.h:135:12: warning: 'struct timeval' declared inside parameter list will not be visible outside of this definition or declaration
     struct timeval *tv,

=====

I think the reason for this is that the struct timeval isn't declared anywhere before the declaration of this function. For me on windows, the structure is defined inside of winsock.h and including it before the other python header files fixes the problem.

[iritkatriel]

timval is defined in sys/time.h.

This would be something to do with your setup, but you did not provide any information about your system and the steps you took to get to this point so it's hard to know what happened.

In any case, 3.7 is no longer maintained so I am closing this. Please create a new issue, with more information, if you are seeing this problem on a current version (>= 3.9).

[mattip]

fwiw, this was fixed for clang in #77532, which became part of 3.12

[sfinktah]

@mattip fwiw, it was worth a lot.

For anyone being annoyed by this warning in py <= 3.11

Add this at ~line 55 of include/cpython/pytime.h (where-ever good python installs are kept).

#ifdef __clang__
struct timeval;
#endif

Actually, this being a Windows+clang specific problem, good pythons are kept at %USERPROFILE%/AppData/Local/Programs/Python/Python311/include/cpython/pytime.h

(everyone else, it was fixed in py 3.12)