Missing setup.py on releases?

[luizribeiro]

While packaging tomlkit 0.11.8 for NixOS we noticed that starting on 0.11.7 the released packages no longer include setup.py (see full discussion on NixOS/nixpkgs#245440).

While setup.py is no longer actually necessary, this creates a circular dependency to build tomlkit moving forward - as tomlkit itself would require poetry to be able to build tomlkit, while poetry itself depends on tomlkit to be built.

Was the removal of setup.py intended?

[luizribeiro]

Ah, it seems like this happened because of python-poetry/poetry-core#318

I guess we could explicitly set tool.poetry.build.generate-setup-file here so we can still build tomlkit without poetry?

I'm going to put up a PR for that.

[frostming]

this creates a circular dependency to build tomlkit moving forward - as tomlkit itself would require poetry to be able to build tomlkit, while poetry itself depends on tomlkit to be built.

This is not true, tomlkit only requires poetry-core to build and the latter has zero-dependency, it doesn't vendor tomlkit either. You may need to investigate carefully to find out the real cause. Or otherwise you may have misconfigured your build process.

[luizribeiro]

Thank you for the clarification, @frostming!

It looks like nixpkgs has the wrong dependencies for poetry-core indeed.