[1.8 backport] remove advice re seeding keyring backends#9219
Merged
neersighted merged 1 commit intopython-poetry:1.8from Apr 22, 2024
Merged
[1.8 backport] remove advice re seeding keyring backends#9219neersighted merged 1 commit intopython-poetry:1.8from
neersighted merged 1 commit intopython-poetry:1.8from
Conversation
neersighted
added
area/docs
|
Deploy preview for website ready! ✅ Preview Built with commit 24582d1. |
Secrus
approved these changes
Mar 25, 2024
(cherry picked from commit 75453c2)
radoering
force-pushed
the
backport/9164-1.8
branch
from
24582d1 to
99f6ba7
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #9164 to 1.8
I can't make sense of the advice that this pull request removes: so this is an invitation either to remove it or to explain it!
Surely all that matters to poetry is that the relevant keyring backend is in its own virtual environment? What reason would there be for also seeding the project virtual environment with that backend?
this comes from #4086 so I guess I should tag @Darsstar, though of course three years later it would be completely reasonable to have forgotten or stopped caring.
even if right in principle the doc is not enormously helpful. As far as I am aware the imagined plug-in remains imaginary - and I would not know from reading this text what I was supposed to do anyway. So I might encourage removing it in any case.