Skip to content

[1.8] lazy-wheel: allow redirects for HEAD request #9089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radoering merged 1 commit into from
Mar 2, 2024
+13 −1
Merged

[1.8] lazy-wheel: allow redirects for HEAD request #9089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/poetry/inspection/lazy_wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,9 @@ def _content_length_from_head(self) -> int:
:raises HTTPRangeRequestUnsupported: if the response fails to indicate support
for "bytes" ranges."""
self._request_count += 1
head = self._session.head(self._url, headers=self._uncached_headers())
head = self._session.head(
self._url, headers=self._uncached_headers(), allow_redirects=True
)
head.raise_for_status()
assert head.status_code == codes.ok
accepted_range = head.headers.get("Accept-Ranges", None)
Expand Down
10 changes: 10 additions & 0 deletions tests/inspection/test_lazy_wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,16 @@ def test_metadata_from_wheel_url_with_redirect(
)


def test_metadata_from_wheel_url_with_redirect_after_500(
assert_metadata_from_wheel_url: AssertMetadataFromWheelUrl,
) -> None:
assert_metadata_from_wheel_url(
negative_offset_error=(codes.internal_server_error, b"Internal server error"),
expected_requests=10,
redirect=True,
)


@pytest.mark.parametrize(
("negative_offset_failure", "expected_requests"),
[
Expand Down