Skip to content

fix: fix poetry shell for nushell #7919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radoering merged 1 commit into from
May 15, 2023
Merged

fix: fix poetry shell for nushell #7919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/poetry/utils/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,14 @@ def activate(self, env: VirtualEnv) -> int | None:

if self._name in ["zsh", "nu"]:
c.setecho(False)
if self._name == "zsh":
# Under ZSH the source command should be invoked in zsh's bash emulator
c.sendline(f"emulate bash -c '. {shlex.quote(str(activate_path))}'")

if self._name == "zsh":
# Under ZSH the source command should be invoked in zsh's bash emulator
c.sendline(f"emulate bash -c '. {shlex.quote(str(activate_path))}'")
else:
cmd = f"{self._get_source_command()} {shlex.quote(str(activate_path))}"
if self._name == "fish":
# Under fish "\r" should be sent explicitly
if self._name in ["fish", "nu"]:
# Under fish and nu "\r" should be sent explicitly
cmd += "\r"
c.sendline(cmd)

Expand Down Expand Up @@ -143,8 +144,10 @@ def _get_activate_script(self) -> str:
return "activate" + suffix

def _get_source_command(self) -> str:
if self._name in ("fish", "csh", "tcsh", "nu"):
if self._name in ("fish", "csh", "tcsh"):
return "source"
elif self._name == "nu":
return "overlay use"
return "."

def __repr__(self) -> str:
Expand Down