unstick virtualenv on windows, bump platformdirs#7484
Merged
radoering merged 4 commits intopython-poetry:masterfrom Apr 21, 2023
Merged
unstick virtualenv on windows, bump platformdirs#7484radoering merged 4 commits intopython-poetry:masterfrom
radoering merged 4 commits intopython-poetry:masterfrom
Conversation
Contributor
Author
|
Not quite: because, as I now recall, the failing test is explicitly testing the (old) PipInstaller. So perhaps the plan needs to be:
|
dimbleby
force-pushed
the
unstick-virtualenv-windows
branch
from
f6cccbe to
bbb6a42
Compare
dimbleby
force-pushed
the
unstick-virtualenv-windows
branch
from
665d1b8 to
52e48a9
Compare
dimbleby
force-pushed
the
unstick-virtualenv-windows
branch
from
52e48a9 to
f1b976c
Compare
Contributor
Author
|
Now updated to include a platformdirs bump, #7640 Note that this is kinda confusing because platformdirs reversed its position on which of the MacOS directories should be used to hold configuration. |
dimbleby
changed the title
radoering
reviewed
Apr 20, 2023
dimbleby
force-pushed
the
unstick-virtualenv-windows
branch
from
3cd7f91 to
3488c28
Compare
Contributor
Author
|
windows python 3.9 and the embedded pip still not a happy combination. I suppose the testcase can likely be fixed by adding a non-embedded pip to the ephemeral environment, perhaps that is satisfactory. WIBNI poetry did not have to rely on pip here at all |
radoering
force-pushed
the
unstick-virtualenv-windows
branch
from
982b3f0 to
4b300cf
Compare
radoering
approved these changes
Apr 21, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wondering whether the new installer makes it possible to unstick virtualenv at python3.9 windows - let's ask the CI pipeline.