Skip to content

test(solver): increase test coverage by searching for copies instead of the same instance #5695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abn merged 1 commit into from
May 26, 2022
Merged

test(solver): increase test coverage by searching for copies instead of the same instance #5695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions tests/mixology/version_solver/test_dependency_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

from copy import deepcopy
from typing import TYPE_CHECKING

from poetry.factory import Factory
Expand Down Expand Up @@ -34,8 +35,10 @@ def test_solver_dependency_cache_respects_source_type(
cache.search_for(dependency_git)
assert not cache.search_for.cache_info().hits

packages_pypi = cache.search_for(dependency_pypi)
packages_git = cache.search_for(dependency_git)
# increase test coverage by searching for copies
# (when searching for the exact same object, __eq__ is never called)
packages_pypi = cache.search_for(deepcopy(dependency_pypi))
packages_git = cache.search_for(deepcopy(dependency_git))

assert cache.search_for.cache_info().hits == 2
assert cache.search_for.cache_info().currsize == 2
Expand Down Expand Up @@ -90,8 +93,10 @@ def test_solver_dependency_cache_respects_subdirectories(
cache.search_for(dependency_one_copy)
assert not cache.search_for.cache_info().hits

packages_one = cache.search_for(dependency_one)
packages_one_copy = cache.search_for(dependency_one_copy)
# increase test coverage by searching for copies
# (when searching for the exact same object, __eq__ is never called)
packages_one = cache.search_for(deepcopy(dependency_one))
packages_one_copy = cache.search_for(deepcopy(dependency_one_copy))

assert cache.search_for.cache_info().hits == 2
assert cache.search_for.cache_info().currsize == 2
Expand Down