layout: make original toml content optional#3008
Merged
finswimmer merged 3 commits intopython-poetry:masterfrom Oct 1, 2020
Merged
layout: make original toml content optional#3008finswimmer merged 3 commits intopython-poetry:masterfrom
finswimmer merged 3 commits intopython-poetry:masterfrom
Conversation
sdispater
previously approved these changes
Sep 30, 2020
finswimmer
requested changes
Oct 1, 2020
Member
finswimmer
left a comment
finswimmer
left a comment
There was a problem hiding this comment.
Are the changes in configuration.md, poetry.lock and pyproject.toml intended to be in this PR?
Otherwise looks good 👍
Member
Author
|
Yes. They are separated by commits. :) The doc fix is linting related issue that crept into master, and the core bump is due to checks failing on python 2.7. See fixes to core 1.0.0rc2. |
Merged
finswimmer
approved these changes
Oct 1, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced via #2448.