feat: compile flag for installer#88
Merged
Merged
Conversation
radoering
reviewed
Mar 23, 2024
KineticCookie
force-pushed
the
compile-option
branch
from
182e24f to
010a52b
Compare
radoering
force-pushed
the
compile-option
branch
from
010a52b to
47f71fa
Compare
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
radoering
approved these changes
Jul 23, 2024
This was referenced Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #89
Hi! First PR here 😅
I noticed that
--compileoption used inpoetry installis not utilized in venv bundler.In this PR I added a passthrough of the flag to the installer as in poetry itself:
https://github.com/python-poetry/poetry/blob/d18ca5d2e751d5a44e48da38926662c90bcb23d1/src/poetry/console/commands/install.py#L147