fix parsing platform_release with kernel versions containing multiple + characters#930
Merged
radoering merged 2 commits intopython-poetry:mainfrom Mar 28, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the generic release version regex to accept plus signs in non-Python version build metadata (e.g., kernel strings in platform_release) and extends tests to cover the new behavior while keeping invalid/valid marker constraints behavior intact. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The updated
RELEASE_PATTERNnow allows consecutive+characters with no alphanumeric between them (e.g.1.0++foo), so consider tightening the character class to only allow+as a separator between non-empty segments (for example using a subpattern like[0-9a-zA-Z-]+(?:\+[0-9a-zA-Z-]+)*).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The updated `RELEASE_PATTERN` now allows consecutive `+` characters with no alphanumeric between them (e.g. `1.0++foo`), so consider tightening the character class to only allow `+` as a separator between non-empty segments (for example using a subpattern like `[0-9a-zA-Z-]+(?:\+[0-9a-zA-Z-]+)*`).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…le `+` characters
for more information, see https://pre-commit.ci
68363a0 to
6478608
Compare
This was referenced Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry/poetry#10786
Summary by Sourcery
Adjust version parsing to correctly handle non-Python platform release strings with multiple '+' characters.
Bug Fixes:
Tests: