constraints: make EmptyConstraint hashable and tidy up a bit#513
Merged
neersighted merged 1 commit intopython-poetry:mainfrom Oct 30, 2022
Merged
constraints: make EmptyConstraint hashable and tidy up a bit#513neersighted merged 1 commit intopython-poetry:mainfrom
neersighted merged 1 commit intopython-poetry:mainfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
neersighted
approved these changes
Oct 30, 2022
Member
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
LGTM overall; however I'm not a huge fan of BaseConstaint, that's neither here nor there for this PR. How painful would it be to refactor it into an ABC in the future?
Member
Author
It's a bit of work (at least if we want to do it properly) because not all (concrete) sub classes implement all methods that raise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up of #466 which handled generic constraints, this one handles version constraints