support for file dependencies with subdirectories#467
Merged
radoering merged 1 commit intopython-poetry:mainfrom May 8, 2023
Merged
support for file dependencies with subdirectories#467radoering merged 1 commit intopython-poetry:mainfrom
radoering merged 1 commit intopython-poetry:mainfrom
Conversation
radoering
force-pushed
the
zip-subdir-file-dependency
branch
from
73de205 to
43b9e0b
Compare
radoering
force-pushed
the
zip-subdir-file-dependency
branch
2 times, most recently
from
19740f4 to
1962c43
Compare
radoering
force-pushed
the
zip-subdir-file-dependency
branch
2 times, most recently
from
bf17206 to
561d07e
Compare
radoering
force-pushed
the
zip-subdir-file-dependency
branch
2 times, most recently
from
8648178 to
1714041
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
radoering
force-pushed
the
zip-subdir-file-dependency
branch
2 times, most recently
from
613a114 to
ac23f76
Compare
2 tasks
radoering
force-pushed
the
zip-subdir-file-dependency
branch
3 times, most recently
from
9cc1105 to
74bcc47
Compare
Secrus
approved these changes
May 8, 2023
…nd url dependencies)
radoering
force-pushed
the
zip-subdir-file-dependency
branch
from
74bcc47 to
b2b2cce
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up of #398 to support local zip files in addition to urls
Some pitfalls:
path) in pyproject.toml. Although there is no added value in having a directory dependency with a subdirectory, it will be valid according to the schema. Internallypath = "folder/sub"andpath = "folder", subdirectory = "sub"are not distinguished, path and subdirectory are just joined.poetry addwill probably only be able to add a file dependency with a subdirectory via URI, e.g.file:///tmp/file.zip#subdirectory=subbecause#subdirectory=subcan't be added to a path.poetry addbecause there seems to be no valid URI representation for relative paths (or at least we don't support any).