Skip to content

fix python_constraint_from_marker() #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neersighted merged 1 commit into from
Aug 2, 2022
Merged

fix python_constraint_from_marker() #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/poetry/core/packages/utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ def normalize_python_version_markers( # NOSONAR
version = "~" + version
op = ""

elif op == "!=" and "*" not in version:
elif op == "!=" and "*" not in version and version.count(".") < 2:
version += ".*"

elif op in ("<=", ">"):
Expand Down
5 changes: 5 additions & 0 deletions tests/packages/utils/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@ def test_convert_markers(
('python_version >= "3.9" or sys_platform == "linux"', "*"),
# relevant python_version
('python_version >= "3.9" and sys_platform == "linux"', ">=3.9"),
# exclude specific version
(
'python_version >= "3.5" and python_full_version != "3.7.6"',
">=3.5,<3.7.6 || >3.7.6",
),
],
)
def test_get_python_constraint_from_marker(marker: str, constraint: str) -> None:
Expand Down