Refactor: make method with_features available for Dependency#392
Merged
neersighted merged 3 commits intopython-poetry:mainfrom Jun 4, 2022
Merged
Refactor: make method with_features available for Dependency#392neersighted merged 3 commits intopython-poetry:mainfrom
neersighted merged 3 commits intopython-poetry:mainfrom
Conversation
radoering
force-pushed
the
dependency-with-features
branch
from
625bf2b to
55bcd1e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
neersighted
approved these changes
Jun 4, 2022
radoering
added a commit
to radoering/poetry
that referenced
this pull request
Jun 5, 2022
…re with # python-poetry/poetry-core#392 is available and python-poetry/poetry-core#375 is available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally I just wanted to make the method with_features() available for Dependency. Then, I noticed that some redundant code can be removed with a little refactoring.