lint and fix pep8 naming conventions#247
lint and fix pep8 naming conventions#247danieleades wants to merge 1 commit intopython-poetry:mainfrom
Conversation
8421396 to
356766d
Compare
|
This will probably cause some breakage, yeah. It's a bigger codebase, but I think this would be good to try in poetry itself first since it has no consumers outside of plugins (and the plugin API is not yet stable). |
downstream tests passed. wasn't expecting that |
|
grepping the code, it's clear that the Exception class is used downstream. I guess the 'downstream' test case doesn't cover it. I guess both repos will need to be changed together, and it's a major version bump for |
356766d to
d1bd80e
Compare
|
rebased |
d1bd80e to
3e0e3fc
Compare
|
We could ignore the |
3e0e3fc to
03a2466
Compare
03a2466 to
49fafcc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Superseded by #767, this PR was too much of a rebase hell. |








i'll see what the CI does, but i'm expecting there's a reasonable chance this is a breaking change for downstream