Skip to content

lint and fix pep8 naming conventions#247

Closed
danieleades wants to merge 1 commit intopython-poetry:mainfrom
danieleades:refactor/pep8-naming
Closed

lint and fix pep8 naming conventions#247
danieleades wants to merge 1 commit intopython-poetry:mainfrom
danieleades:refactor/pep8-naming

Conversation

@danieleades
Copy link
Copy Markdown
Contributor

i'll see what the CI does, but i'm expecting there's a reasonable chance this is a breaking change for downstream

@neersighted
Copy link
Copy Markdown
Member

This will probably cause some breakage, yeah. It's a bigger codebase, but I think this would be good to try in poetry itself first since it has no consumers outside of plugins (and the plugin API is not yet stable).

See python-poetry/poetry#4776.

@danieleades
Copy link
Copy Markdown
Contributor Author

This will probably cause some breakage, yeah. It's a bigger codebase, but I think this would be good to try in poetry itself first since it has no consumers outside of plugins (and the plugin API is not yet stable).

See python-poetry/poetry#4776.

downstream tests passed. wasn't expecting that

@danieleades
Copy link
Copy Markdown
Contributor Author

grepping the code, it's clear that the Exception class is used downstream. I guess the 'downstream' test case doesn't cover it.

I guess both repos will need to be changed together, and it's a major version bump for core

@danieleades
Copy link
Copy Markdown
Contributor Author

rebased

@finswimmer
Copy link
Copy Markdown
Member

We could ignore the N818 error for now, to introduce pep-naming anyway.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Secrus
Copy link
Copy Markdown
Member

Secrus commented Oct 2, 2024

Superseded by #767, this PR was too much of a rebase hell.

@Secrus Secrus closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants