remove dev-dependencies resolution from the build#101
Merged
abn merged 4 commits intopython-poetry:masterfrom Oct 22, 2020
roxchkplusony:2174/remove-dev-from-build
Merged
remove dev-dependencies resolution from the build#101abn merged 4 commits intopython-poetry:masterfrom roxchkplusony:2174/remove-dev-from-build
abn merged 4 commits intopython-poetry:masterfrom
roxchkplusony:2174/remove-dev-from-build
Conversation
abn
requested changes
Oct 14, 2020
abn
requested changes
Oct 22, 2020
Member
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
You seem to have inadvertantly moved tests/json/__init__.py. Additionally, it could be great if we could parametrise the tests reduce some duplication (optional).
Otherwise looks good.
Contributor
Author
|
Added back the init.py file I had inadvertently deleted. I don't see a great deduplication opportunity with the two test files, but let me know if your optional becomes mandatory. Otherwise, I hope I can get an approve. |
abn
approved these changes
Oct 22, 2020
This was referenced Nov 19, 2020
|
Any plans to release this fix soon? 🙏 |
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates-to: python-poetry/poetry#2174