Skip to content

2.3.4 #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akx merged 3 commits into from
Apr 22, 2016
Merged

2.3.4 #394

akx merged 3 commits into from
Apr 22, 2016

Conversation

@akx
Copy link
Member

@akx akx commented Apr 22, 2016

No description provided.

@akx akx assigned sils Apr 22, 2016
@sils
Copy link
Member

sils commented Apr 22, 2016

which are cherry picked and already reviewed?

@akx
Copy link
Member Author

akx commented Apr 22, 2016

@sils1297 All changes here are already in master.

@akx
Copy link
Member Author

akx commented Apr 22, 2016 •
edited
Loading

@sils1297 : Namely,

@akx
Copy link
Member Author

akx commented Apr 22, 2016

Bah, it seems I fudged up the cherry-pick somehow. Just a moment...

@akx akx force-pushed the 2.3.4 branch 2 times, most recently from a427dca to 954808e Compare April 22, 2016 06:57
@codecov-io
Copy link

codecov-io commented Apr 22, 2016

Current coverage is 90.07%

Merging #394 into release/2.3 will increase coverage by +0.06% as of 6710162

@@            release/2.3    #394   diff @@
===========================================
  Files                24      24       
  Stmts              3935    3950    +15
  Branches              0       0       
  Methods               0       0       
===========================================
+ Hit                3542    3558    +16
  Partial               0       0       
+ Missed              393     392     -1

Review entire Coverage Diff as of 6710162

Powered by Codecov. Updated on successful CI builds.

@sils
Copy link
Member

sils commented Apr 22, 2016

why does the commit message of f619102 have no reason? Can you please never merge a revert without a reason?

@akx
Copy link
Member Author

akx commented Apr 22, 2016

@sils1297 Sure thing, will mandate refs in revert commit messages in the future. (GitMate rule idea? :) )

For that particular bug, see #391 anyway.

jtwang and others added 3 commits April 22, 2016 11:40
@jtwang @akx
Revert "import_cldr: if lxml is installed, use it"
b4d95cd 
This reverts commit 9b5c7f3.

Refs python-babel#391
@akx
Fix CLI regressions (see below for details)
fe2e6e4 
This is a combination of the test suite improvement fbc1648 and the frontend changes in 414aec5..ee8abd6.

* Harmonize extraction keyword parsing between distutils and standalone CLI (python-babel#388, python-babel#384, python-babel#311)
* Don't use unicode-variant %r for logging
* extract: don't die badly when no input paths are specified in optparse mode
* Remind the optparse CLI about `extract -s` (a shorthand for `--strip-comments`) (python-babel#390)
* Teach the optparse CLI about the parameter aliases it had forgotten in python-babel#311 (python-babel#390)
@akx
Bump to 2.3.4
915236c
@akx
Copy link
Member Author

akx commented Apr 22, 2016

@sils1297 I added a refs to the revert message here.

@sils
Copy link
Member

sils commented Apr 22, 2016

thanks, filed coala/coala-bears#337. We also added an option to detect non imperative tense for commit messages :)

@sils
Copy link
Member

sils commented Apr 22, 2016

ack b4d95cd fe2e6e4 915236c

@sils
Copy link
Member

sils commented Apr 22, 2016

@akx feel free to merge and release :)

@akx akx merged commit 6a1491a into python-babel:release/2.3 Apr 22, 2016
@akx akx deleted the 2.3.4 branch May 27, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sils sils

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@akx @sils @codecov-io @gitmate-bot @jtwang