Skip to content

Fix day period formatting (#378) #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akx merged 2 commits into from
Apr 8, 2016
Merged

Fix day period formatting (#378) #379

akx merged 2 commits into from
Apr 8, 2016

Conversation

@akx
Copy link
Member

@akx akx commented Apr 8, 2016

See issue #378 for discussion.

We should release 2.3.2 when this fix is in, if no other bugs/regressions are found.

@akx akx added the bug label Apr 8, 2016
@akx akx mentioned this pull request Apr 8, 2016
Closed
akx added 2 commits April 8, 2016 09:13
@akx
dates: Use format context and fallback through widths
c028a09 
`zh_Hant` locale data does not have names for the
`am` and `pm` day periods in the `format`/`abbreviated` context,
so fallback logic is added to deal with that eventuality.

Fixes python-babel#378
@akx
Add smoke tests for basic operations
971e706 
Refs python-babel#378
@codecov-io
Copy link

codecov-io commented Apr 8, 2016

Current coverage is 89.34%

Merging #379 into master will decrease coverage by -0.62% as of e4604e9

@@            master    #379   diff @@
======================================
  Files           24      24       
  Stmts         3927    3931     +4
  Branches         0       0       
  Methods          0       0       
======================================
- Hit           3533    3512    -21
  Partial          0       0       
- Missed         394     419    +25

Review entire Coverage Diff as of e4604e9

Powered by Codecov. Updated on successful CI builds.

@akx
Copy link
Member Author

akx commented Apr 8, 2016

I kinda want the same stuff @codecov-io is smoking...

@akx
Copy link
Member Author

akx commented Apr 8, 2016

Self-merging as this is a regression fix.

The only failing CI is Codecov, which is on some sort of robot drugs... as usual.

@akx akx merged commit e4ae94c into python-babel:master Apr 8, 2016
@akx akx deleted the fix-378 branch April 8, 2016 07:44
@pyup-bot pyup-bot mentioned this pull request Apr 11, 2017
Closed
@pyup-bot pyup-bot mentioned this pull request Apr 27, 2017
Open
@pyup-bot pyup-bot mentioned this pull request May 12, 2017
Closed
@pyup-bot pyup-bot mentioned this pull request Jul 4, 2017
Merged
This was referenced Aug 17, 2017
Merged
Open
This was referenced Aug 26, 2017
Merged
Closed
@pyup-bot pyup-bot mentioned this pull request Sep 4, 2017
Merged
@pyup-bot pyup-bot mentioned this pull request Sep 14, 2017
Open
@pyup-bot pyup-bot mentioned this pull request Oct 17, 2017
Closed
@pyup-bot pyup-bot mentioned this pull request Nov 3, 2017
Closed
This was referenced Jan 15, 2018
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jtwang jtwang

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@akx @codecov-io @jtwang @gitmate-bot