-
Notifications
You must be signed in to change notification settings - Fork 462
Character order and measurement systems #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Character order and measurement systems #368
Conversation
Current coverage is
|
|
thank you very much @akx . if you could, please tell me when to tell pint people to use upstream instead of my babel. |
| return self._data['measurement_systems'] | ||
|
|
||
| @property | ||
| def character_order(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would have been a great use of a Python 3.4 Enum. Just an observation, no need to do anything here. :)
|
Assigned @jtwang for having done initial review on this. |
e24c15a to
f4fae83
Compare
* Refactor into a separate function * Use `_import_type_text` when importing measurement systems
f4fae83 to
99dc0c7
Compare
|
Disregard the Codecov fail, btw. I think it's being confused again... |
|
@akx - OK to merge! Just the nit about two methods, ignore if you want. ;) |
|
Nits acknowledged. |
|
Gah, this PR shows up in my list of open PRs even if it's merged. EDIT: Welp, adding this comment fixed the issue. |
This is a fixed version of @alexbodn 's PR #367.
The
get_unit_nameAPI from that PR is intentionally excluded; aformat_unitAPI will be included in a subsequent PR.