Skip to content

Conversation

@mxsasha
Copy link
Contributor

@mxsasha mxsasha commented Nov 23, 2014

This adds a simple list of all valid keys for get_global() to the documentation. I've already included the territory_languages key, which is introduced in PR #122.

@sils
Copy link
Member

sils commented Aug 5, 2015

@erikr rebase should also fix the tests

@sils
Copy link
Member

sils commented Aug 5, 2015

also can you use imperative present tense for commit shortlog? Minor nitpick because you seem to have several PRs waiting for review.

@codecov-io
Copy link

Current coverage is 83.38%

Merging #123 into master will not affect coverage as of 3405b4f

@@            master    #123   diff @@
======================================
  Files           22      22       
  Stmts         3756    3756       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit           3132    3132       
  Partial          0       0       
  Missed         624     624       

Review entire Coverage Diff as of 3405b4f

Powered by Codecov. Updated on successful CI builds.

@etanol
Copy link
Contributor

etanol commented Nov 24, 2015

@erikr Why did you create a new PR instead of committing this on top of #122 ?

@akx akx mentioned this pull request Jan 3, 2016
@akx
Copy link
Member

akx commented Jan 11, 2016

This was closed via #315.

@akx akx closed this Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants