fix compatibility with pytest 8.2 by restoring deleted finalizers#278
Merged
icemac merged 2 commits intopytest-dev:masterfrom Nov 5, 2024
Merged
fix compatibility with pytest 8.2 by restoring deleted finalizers#278icemac merged 2 commits intopytest-dev:masterfrom
icemac merged 2 commits intopytest-dev:masterfrom
Conversation
icemac
approved these changes
Nov 5, 2024
Contributor
icemac
left a comment
icemac
left a comment
There was a problem hiding this comment.
I like the change. As it fixes our tests it is definitly a step forward.
Contributor
|
Thank you very much for digging into this issue. |
Contributor
|
Hm, this seems to have fixed the problems for 8.3, when running explicitly against 8.2 there are still failures, see https://github.com/pytest-dev/pytest-rerunfailures/actions/runs/11687465600/job/32545646408?pr=279 as an example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #267
The problem in #267 arose from pytest-dev/pytest#11833, which made pytest not add finalizers for cached fixtures.
pytest_runtest_teardownrelied on cached fixtures getting their finalizers repeatedly re-added, as it deleted all(?) finalizers on every re-run. This PR makes sure to save away those finalizers, so we can add them back when we're done rerunning and let them execute.I suspect the current solution will break with xdist or something, given that
suspended_finalizersis a global dict. So it'd probably be more prudent to do something with the database?This is my first time looking at pytest-rerunfailures, so I'd love if any current maintainers wanted to have opinions or even finish up the PR now that I've mostly figured out the messy part.