Fix passing constraints file path into pipx install operation via --pip-args

[guysalt]

closes #1389

• I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Fix error with pipx install Command Using Relative Path for Pip Arguments

Test plan

Tested by running

pipx install --pip-args=--constraint=some_constraint_file.txt some_package_inside_constraint_file

[chrysle]

Thanks for catching this! Please also extend the docstring of the changed function.

[guysalt]

Thanks for catching this! Please also extend the docstring of the changed function.

I have considered this * Convert local paths to absolute paths as the same description, doesn't it?

[chrysle]

Great, let's get down to business once again, then. Don't fail to inform us about your XONSH compatibility research.
Could you add a functional test, please?

[guysalt]

Great, let's get down to business once again, then. Don't fail to inform us about your XONSH compatibility research. Could you add a functional test, please?

sure, hope to do so soon...

[guysalt]

Great, let's get down to business once again, then. Don't fail to inform us about your XONSH compatibility research. Could you add a functional test, please?

hey, so I wrote a test, but i will glad if you help me with a question...

the test right now is not passing and I dont understand why.
first I wrote a test just for checking the path is absolute and the command working (with empty constraint file).

then I want to add a check for installing the right constraint from the file.
when I put in the constraint file pycowsay==0.0.0.1 it does not installing the package (says something about conflict).

and if I run similar command on my terminal its working, so im trying to understand what is the different?
maybe you can help me understand its related to the tests architecture or something like this.

[guysalt]

Great, let's get down to business once again, then. Don't fail to inform us about your XONSH compatibility research. Could you add a functional test, please?

hey, so I wrote a test, but i will glad if you help me with a question...

the test right now is not passing and I dont understand why. first I wrote a test just for checking the path is absolute and the command working (with empty constraint file).

then I want to add a check for installing the right constraint from the file. when I put in the constraint file pycowsay==0.0.0.1 it does not installing the package (says something about conflict).

and if I run similar command on my terminal its working, so im trying to understand what is the different? maybe you can help me understand its related to the tests architecture or something like this.

understand the catch, add pycowsay==0.0.0.1 to the tests_packages files...
need to see all the tests pass

[chrysle]

Thanks for adding the tests.

Approved to early

[guysalt]

Its seems that the tests fails exactly on what I was trying to tell you on the pip args split...

that the splitting does now working on the workflow, as it does now working on my terminal (xonsh).

do you have a clue why does it happening?

[guysalt]

Hey again @chrysle

I was a little bit busy, I would like to keep going and finish this please.

We discussed about that thing with the ' on the first thread here.
Now, after I add the last commit that strip the ' char, all the tests are working...

Please review it, and let me know if you still don't want the striping on the pip args.
Thanks

[chrysle]

Looks good. Please add a comment to the code explaining why it is necessary, then I think this is mergeable.

[guysalt]

Looks good. Please add a comment to the code explaining why it is necessary, then I think this is mergeable.

Thanks, done.

[chrysle]

Thanks!