refactor: Split exceptions into a package - #14176
Open
ichard26 wants to merge 9 commits into
Open
Conversation
ichard26
force-pushed
the
errors/refactor
branch
2 times, most recently
from
July 15, 2026 03:31
a4ed1eb to
9d0cea7
Compare
1 task
ichard26
force-pushed
the
errors/refactor
branch
from
August 12, 2026 00:30
9d0cea7 to
1e872b1
Compare
ichard26
force-pushed
the
errors/refactor
branch
from
August 12, 2026 00:38
1e872b1 to
67f1bee
Compare
Member
Author
|
I've rebased this onto current main and massively simplified the diff by re-exporting the moved exceptions in Since this is going to conflict with the other error improvement work I'm doing, I'd like to get this landed sooner than later. Unless someone objects, I'll merge this within a few days. |
2ykwang
reviewed
Aug 12, 2026
avoid circular import
avoid circular import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm planning to add even more diagnostic errors, but
exceptions.pyis starting to become unwieldy. I've converted it into a package to permit for further growth. To start, I've moved the following exceptions to their own submodules.pyprojectMissingPyProjectBuildRequires,InvalidPyProjectBuildRequireswheelInvalidWheelFilename,UnsupportedWheel,InvalidWheelhashesHashErrors,HashError,VcsHashUnsupported,DirectoryUrlHashUnsupported,HashMissing,HashUnpinned,HashMismatchuninstallUninstallMissingRecord,LegacyDistutilsInstallbuild_envBuildDependencyInstallError,VenvImportError,VenvCreationErrornetworkNetworkConnectionError,ConnectionFailedError,ConnectionTimeoutError,SSLMissingError,SSLVerificationError,ProxyConnectionError,IncompleteDownloadErrorI've left the remaining exceptions alone in
exceptions/__init__.py. I'm happy to hear suggestions for more groupings.In the near-to-medium future, I'm planning to add new diagnostic errors to
wheel(and possibly a newresolutiongroup).Tip
This is probably much easier to review commit-by-commit.