fix: pyodide build fails when dependency-versions is set#2548
Merged
Conversation
joerick
requested review from
agriyakhetarpal,
hoodmane and
ryanking13
as code owners
Contributor
|
Ahh, so that's it. I still think something like #2544 would be good eventually, as our limits (like capping click, or selecting a pyodide version) aren't applying to unpinned environments. |
henryiii
approved these changes
Aug 11, 2025
agriyakhetarpal
approved these changes
Aug 11, 2025
Member
agriyakhetarpal
left a comment
agriyakhetarpal
left a comment
There was a problem hiding this comment.
This LGTM from my end – yes, auditwheel-emscripten is now at 0.2.0 after RPATH support was added. We used to previously pin it but there is no reason to do so now. Thank you!
joerick
changed the title
Contributor
|
Thanks @joerick! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the pyodide failures on main.
auditwheel-emscripten is already a dep of pyodide-build, and cibuildwheel doesn't use it directly. But by listing it in this "pip install" command, it was causing the resolver to backtrack to 0.25.0 of pyodide-build, because more recent versions of pyodide-build pin auditwheel-emscripten.
Pyodide folks, does that sound right to you?