fix: do not use uv to setup python on windows when conditions are not met#2005
Merged
fix: do not use uv to setup python on windows when conditions are not met#2005
uv to setup python on windows when conditions are not met#2005Conversation
Czaki
approved these changes
Sep 14, 2024
Contributor
Czaki
left a comment
Czaki
left a comment
There was a problem hiding this comment.
Does the Linux not need similar refactor?
Member
Author
Linux could if we want to push consistency even further but given it's used in only one place on Linux, the risk of modifying one place and forgetting the other does not exist there. |
joerick
approved these changes
Sep 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uvwas still used insetup_pythonon Windows even whenuse_uvwasFalse.This PR fixes
setup_pythonto fallback tobuildfrontend name instead ofbuild[uv]in that case.Added
can_use_uvfunction to make sure wether or notuvis usable in a single place rather than duplicate the checks (and potentially forgetting one out of two if the conditions were to change).