compute_log_prior: make subsequent arguments keyword only#8123
Merged
aloctavodia merged 1 commit intopymc-devs:mainfrom Feb 28, 2026
Merged
compute_log_prior: make subsequent arguments keyword only#8123aloctavodia merged 1 commit intopymc-devs:mainfrom
compute_log_prior: make subsequent arguments keyword only#8123aloctavodia merged 1 commit intopymc-devs:mainfrom
Conversation
Documentation build overview
Show files changed (4 files in total): 📝 4 modified | ➕ 0 added | ➖ 0 deleted
|
Contributor
Author
|
Although by the test (in #8122 ) it was evident that compute_log_prior was not enforcing keyword-only arguments, the test failed prior to the signature fix and passed once the arguments were made keyword-only. |
compute_log_prior: make subsequent arguments keyword only
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8123 +/- ##
=======================================
Coverage 91.50% 91.50%
=======================================
Files 123 123
Lines 19821 19821
=======================================
Hits 18137 18137
Misses 1684 1684
🚀 New features to boost your workflow:
|
aloctavodia
approved these changes
Feb 28, 2026
Contributor
Author
|
Thanks @aloctavodia @ricardoV94 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I closed the previous PR (#8122) prematurely while trying to resolve pre-commit autofix failures, which ended up being a distraction from the actual change.
This PR keeps things minimal and focused: it enforces keyword-only arguments for compute_log_prior, aligning its signature with compute_log_likelihood and preventing accidental positional argument usage.
As requested in the earlier discussion, the test case has been removed and only the signature fix remains.