Implement Uniform and TruncatedNormal dims distributions#8065
Implement Uniform and TruncatedNormal dims distributions#8065jessegrabowski merged 2 commits intopymc-devs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8065 +/- ##
==========================================
+ Coverage 90.80% 90.83% +0.02%
==========================================
Files 121 121
Lines 19443 19500 +57
==========================================
+ Hits 17656 17713 +57
Misses 1787 1787
🚀 New features to boost your workflow:
|
If you wonder why, I think that's what This wouldn't have been a problem if pytensor function supported arbitrary tuple/list input/output format like any modern jit library does... We should open an issue for that |
OriolAbril
left a comment
There was a problem hiding this comment.
everything looks and sounds good, I'll try to join the hackathons starting next week to go back to more active contributions on label related things
|
@OriolAbril was there a reason you didn't approve the PR? Did you want someone else to review? |
04d624e to
97f9fda
Compare
With the constraint that for free rvs the bounds must be constant. This touches on a limitation we have on transforms that depend on parameters. The previous strategy was to pass the rv inputs to the transform, but this doesn't work for derived variables like
XTensorFromTensorandDimShuffledRVs, since the inputs of those are not the ones needed for the transform.I'll be thinking about how to better handle this, so we can lift the restriction.
Also fixes a bug in
eval_rv_shapeswithXTensorVariablesfor which.shapereturns tuples instead of a tensor